Updating UPN and SAM in one pass

I’ve got a .csv file formatted as shown below.

I want to take
UPN: lastf@domain.com
SAM: lastf

and update them to:
UPN: first.last@domain.com
SAM: first.last

CSV format for import

I’ve already combined GivenName.SN@domain.com (UPN) and GivenName.SN (SAM) in the CSV file and have that ready for import.

My question is, will it work as written, or does it need to be two separate actions, first change the UPN, then change the SAM?

function Update-ADSamAccountName_UPN {
    [CMDLETBINDING(SupportsPaging = $true,
                SupportsShouldProcess = $true)]
    BEGIN {
    } #end BEGIN
    Import-Csv c:\temp\Sam_UPN-Import.csv | ForEach-Object {Set-ADUser -Identity $_.samAccountName -Replace @{UserPrincipalName=$_.NewUserPrincipleName;SamAccountName=$_.NewSamAccountName}}
    } #end PROCESS

    END {
    } #end END

} #end Update-ADSamAccountName_UPN

Have you tried it?

I just did on a test user, and it did in fact work quite well. My concern was if I changed the SAM as part of the script when I went to look for it in the ForEach-Object, it’s now gone. I was probably over-thinking it, but it does in fact work quite well as written. I’ve got several of these scripts I’m using for batch updating ADUC fields, but always use the SAM as the fixed variable on import of .csv, and since that was changing, I second guessed myself.


Oh, OK. No, ForEach object isn’t individually querying the data from AD as it goes. You query the data, ForEach enumerates across what you’ve got. It’ll be a problem if you have more than 1k or so users, because you won’t get them all in one query.