Dicey provided a function definition. If all you did is run it, then of course nothing happened. Functions must be called to execute. Did you call the function? If so, can you post the function call? i.e.
Move-FileToArchive -Keywords @("hello", "world") -SourcePath 'C:\Windows\Temp' -TargetPath 'C:\Windows\yourtarget'
I ran it like your example and received:
The script failed due to call depth overflow.
+ CategoryInfo : InvalidOperation: (0:Int32) , ParentContainsErrorRecordException
+ FullyQualifiedErrorId : CallDepthOverflow
If I run like this:
-Keywords (â528319970â,â200107â)
It finds nothing
Thanks
I opened up one of my files to make sure I was supplying correct parms, but script didnât find anything.
The Keywords param is typed as an array. Look at the examples provided in the functionâs front matter as to how to declare its members. Be sure to also replace the Source and Target paths in the functionâs Begin{} section with your own defaults. For reasons I wonât detail here, this is how I provide some types of parameter defaults.
Delete HelpUri = "Keywords should include: Sender, FileDate, or RecordType", and your users will be able to get this info using Get-Help Move-FileToArchive -Examples
âI had included HelpUri to show where it could be used, and its limitations. It is a great feature when you have documentation stored online that describes a process; itâs practices (e.g., examples), the standards, or a foundational policy.
-dicey
Iâm making two hotfixes to the function because they are integral to an implied successful execution; but Iâm stopping my code review after these.
foreach($file in Get-ChildItem -Path $SourcePath -Depth 1 -Filter "*.bak")
: adds Depth parameter and sets it to 1.
Move-Item -Path $searchFile -Destination $TargetPath;
: removes the return which caused a termination of the function on the first match instance. Additional files in the directory were not reached.
I applied hotfixes but still receive error during script execution:
The script failed due to call depth overflow.
I did it and ran it, it didnât work
You are not helping us help you. You donât show how you run it. I consider this post as âunable to be helpedâ currently as you just plain arenât providing required details.
Sorry this is how I ran it.
Move-FileToArchive -Keywords â528319970â,â200107â -SourcePath "C:\ftp_in" -TargetPath âC:\uploadfilesâ;
I made sure those Keyword where in my file, just to test, but it got the call Depth error.
Create two file directories and put a few files into one and test the function using those items. By using test locations and files, you can narrow down on whether itâs code or something behind the code. Then⌠google away. Get comfortable with VS Code and stepping into code with itâs PowerShell debugger.
For example, if the production directories you are using (yipes?) generate the raised error when hitting Get-ChildItem, then something in the code may need to be altered to accommodate their particular state. Debugging it can pinpoint where the issue happens.
BTW: https://forums.powershell.org/t/call-depth-overflow-error/11274
Although @maarten encountered the error with Active Directory, you might approach that person to see what the solution was.
I think your learning process would start by formatting your code as code here in the forum. 
It is not possible to learn a complex technology like a scripting language or a programming language by guessing or by piecing together some arbitrary snippets of code someone else provided you in a forum. And we cannot teach you how to write functional and working code. It does not make any sense when you donât understand the help you get.
Iâd recommend for you to make some big steps back and restart with learning the very basics of PowerShell first. You have actually got all information you need to solve your initially asked question.
I will quote myself:
I would like to Post some code that I having working but need some help doing that. If I copy paste
I donât think that is what to do. Can you help?
###########################################################
$Path = "C:\ftp_in"
$Searcharry = @("809430399","pr")
$PathArray = @()
$Results = "C:\temp\test.txt"
# This code snippet gets all the files in $Path that end in ".???".
Get-ChildItem $Path -Filter "*.int" |
Where-Object { $_.Attributes -ne "Directory"} |
ForEach-Object {
If (Get-Content $_.FullName | Select-String -Pattern $Searcharry) {
$PathArray += $_.FullName
}
}
Write-Host "Contents of ArrayPath:"
$PathArray | ForEach-Object {$_}
$PathArray | % {$_} | Out-File $Results
##########################################################
This seems to find my searcharry, but how can add the searcharry as parms? not hard coded
I also need it to search an entire folder structure, so Iâm going to add -recurse, but I donât want it
to stop on first hit.
Thanks
Seems like you found the way just by yourself. Great. 
Try to remember how you figured that out and continue to do so.
The information you need are all there. You just have to start to search for them and read them. ⌠completely including the examples.
You may read this as well âŚ
Does your code do that at the moment?
does my code excluding parms look like it should work. I have tested on a small sample set and seems to
work, but would like a more savy PS coder to review for correctness.
Thanks
Thatâs obsolete since Get-ChildItem has the parameter -File.
How about the search lookup any issues there ?
You know that you can provide a file directly to Select-String, donât you? You should start reading the help for the cmdlets youâre about to use. Read it completely including the examples, please.
If it works for you at the moment itâs just fine. Iâd recommend when your skill increases over time you should review your old code from time to time and try to make it better / cleaner / faster / more reliable / fault-tolerant or even just a little easier to read and pleasing for the eyes.
And instead of asking others again and again to review your seemingly working code you could search the internet for code from others for similar tasks and let yourself inspire by some of it. StackOverflow usually is good source of inspiration for PowerShell coders.
So how is the Code Dicey created different from the code I supplied in there functionality? I didnât have to adds Depth parameter and sets it to 1. Trying to understand how original code didnât find matches.