Hi All, I have put together this script to update the UPN and Email Address in AD and AAD for user objects, including setting the Primary SMTP address (loading required AD and EOL modules in advance).
Looking for advice on the SIP part - some objects have SIP specified that need updating and others dont have one. What is the best way of adding something to the script to check if a SIP exists and then update it to the new format or add the SIP if it doesnt exist please?
### Rename UPN in AD ###
Start-Transcript -Path "C:\temp\Contosonew.log" -append
# Get AD Objects in Scope - OU #
Get-ADuser -SearchBase "OU=Users,OU=M365,DC=Contoso,DC=com" -filter * | Select-Object samaccountname,userprincipalname | Export-csv C:\Temp\Users.csv -NoTypeInformation
# Import Users into Variable #
$Users = Import-CSV C:\Temp\Users.csv
# Rename UPN & EmailAddress in AD, Set Primary SMTP Address, Rename AAD UPN #
foreach ($User in $Users) {
$newaddress = "{0}@{1}" -f $user.samaccountname,"contosonew.com"
Set-ADUser -Identity $User.SamAccountName -UserPrincipalName $newaddress -EmailAddress $newaddress
Set-RemoteMailbox -Identity $newaddress -PrimarySMTPAddress $newaddress
}
# Add SIP Address - This will add a SIP for all objects
foreach ($User in $Users) {
$sipaddress = ("{0}{1}@{2}" -f "SIP:",$user.samaccountname,"contosonew.com")
write-host $sipaddress
Set-ADUser -identity $user.SamAccountName -Add @{ProxyAddresses=$sipaddress}
}
# Rename UPN in AAD
foreach ($User in $Users) {
#$newaddress = "{0}@{1}" -f $user.samaccountname,"theitcollaborator.com"
Set-MsolUserPrincipalName -UserPrincipalName $User.userprincipalname -NewUserPrincipalName $newaddress
}
Stop-Transcript
You simply add an if condition inside the loop checking the status of the property you want and place the code for the change inside the scriptblock of the if condition.
Thanks Olaf - tbh the import piece i would have tidied up but appreciate the feedback for removing unnecessary loops.
I will take a look at adding an If Condition for the SIP piece. Thanks as always kind sir.
@Olaf - does the below look correct for the If Condition syntax? Im a little perplexed how to structure the initial “check” of the If statement. Appreciate your advice.
Actually - no. In your condition check you run an AD query for ALL accounts with a SIP address - not just the current one from the loop. If that would work you would query your AD over and over inside your loop for ALL accounts. That will put a lot of stress to your AD. But you use a wildcard in your filter and try to compare it with -eq - that will not work anyway.
Instead I’d recommend to add a -Properties proxyAddresses to your initial query for your $UserList and work with that. To check if there is a SIP address you could run
@Olaf - thanks for your additional input. Does the below look more logical and likely to work?
Effectively if there isnt a SIP then it will create one but if there is, it will update it to match the criteria for the SIP.
This forum is not meant to provide a review for each single step or change you do on your code. You should test your own code in a test environment or at least with test data to see if it does what you want. If not - you try to figure out why by yourself in the first place. And if that does not work you’re very welcome here to ask for help.
@Olaf - appreciate that and apologies for my impertinence here.
I have done testing in my lab and have the following which works fine if the account doesnt have a SIP address already (great for the users needing it added). However if the users already have a SIP, it adds the new, correct format SIP in addition to the existing - where as I would like it to update the existing SIP to the new format.
Appreciate any advice here.
$sipaddress = "{0}{1}@{2}" -f 'SIP:',$user.samaccountname,'Contoso.com'
$sip = $user.proxyAddresses | Where-Object {$_ -match 'SIP:'}
if ($sip.Length -eq 0)
{
Set-ADUser -identity $user.SamAccountName -Add @{ProxyAddresses=$sipaddress}
}
else {
$sip.Address = $sipaddress #This is the part that would need to overwrite the existing SIP
}
So the below finally gives me something that works - adds the SIP if not present and updates the existing SIP (via a remove and add). Will continue to look if there is a neater way to present this code but appreciate any input
