# Help with a legacy script **URL:** \ **Category:** PowerShell Help\ **Created:** [April 22, 2022, 8:04am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158 "2022-04-22T08:04:24Z")\ **Posts on this page:** 6\ **Page:** 1

**Author:** ![F022Y](https://avatars.discourse-cdn.com/v4/letter/f/45deac/32.png) [@F022Y](https://forums.powershell.org/u/F022Y)\ **Post date:** [April 22, 2022, 8:04am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/1 "2022-04-22T08:04:24Z")

Hello all, Some years ago the company hired a contractor to write a PS script to check for servers that were awaiting reboot via WSUS GPOs and give them a kick, after which it then logged this and sent an email. Here I am today trying to understand how it works because we have a new GPO which we want to cover but since adding it the script runs but we don’t get the export or email, i’m not sure how best to proceed as the script does contain info like mailservers and the like. Any help appreciated. Foz ---

**Author:** ![Olaf](https://sea1.discourse-cdn.com/flex019/user_avatar/forums.powershell.org/olaf/32/992_2.png) [@Olaf](https://forums.powershell.org/u/Olaf)\ **Post date:** [April 22, 2022, 8:24am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/2 "2022-04-22T08:24:21Z")

F022Y, Welcome to the forum. 👋🏽 This is a peer to peer forum where we help each other with self written code. We do not review or refactor complete scripts or solutions, sorry. I’d recommend to start to learn the fundamentals of PowerShell first. This will save you from a lot of wasted time and frustrations. In general: when you have sensitive information embedded in the code you need to post you should obfuscate those information. ---

**Author:** ![F022Y](https://avatars.discourse-cdn.com/v4/letter/f/45deac/32.png) [@F022Y](https://forums.powershell.org/u/F022Y)\ **Post date:** [April 22, 2022, 8:35am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/3 "2022-04-22T08:35:14Z")

Hello Olaf, Sorry should have said that i’m familiar with PS but clearly the guy who wrote this has done some things i’m not familiar with as i have amended it previously with no issue but not this section. I only ask about sensitive info as previously i’ve known sites ask for the whole script and this beast is 242 lines. The section i’m interested is as follows:- # Prepare the email to send to Infrastructure team with links to logs ``` $SMTPSvr = $SMTPServer $From = $SendFrom $To = $SendTo $Subject = ("WSUS 2016 Auto Update Reboot Status - " + $todaysDate) $Body = ("

"+$FontSmall+"Can't read this? View in browser

"+$FontNormal+"Please find below the report for WSUS Auto-Rebooting the following servers:

"+$FontNormal+"Total Computers in GPO's:
" + $GPO + ": " + $TotalGPO + "
" + $GPO2 + ": " + $TotalGPO2 + "
" + $GPO3 + ": " + $TotalGPO3 + "
" + $GPO4 + ": " + $TotalGPO4 + "
" + $GPO5 + ": " + $TotalGPO5 + "
" + $GPO6 + ": " + $TotalGPO6 + "

" "Total Computers in all Auto Update GPO's: " + $TotalComputers + "
Total Computers Rebooted: " + $TotalReboots + "
Total Computers Not Rebooted: " + $TotalNoReboots + "
Total Computers WMI Errors: " + $TotalWMIErrors + "
Total Computers Non-contactable: " + $TotalNonContact + "

") $Body += "" $Body += "" $Body += "" $Body += $RebootArray $Body += "" $Body += "" $Body += "" $Body += $NoRebootArray $Body += "


"+$FontHeading+"Computers Rebooted
"+$FontNormal+"Computer Name	"+$FontNormal+"Status	"+$FontNormal+"Time Rebooted


"+$FontHeading+"Computers Not Rebooted
"+$FontNormal+"Computer Name	"+$FontNormal+"Status

Please check the full log at \\Script Server\WSUS\$FileName.

This is an automated email. Do not reply to this email.

" #### Now send the email using Send-MailMessage Send-MailMessage –From $From –To $To –Subject $Subject –Body $Body -BodyAsHtml -SmtpServer $SMTPSvr -Port 25 # Create the html file to view in browser $Body | Out-File ($ExportFilePath + $HTMLFileName) -Encoding ascii ``` ---

**Author:** ![F022Y](https://avatars.discourse-cdn.com/v4/letter/f/45deac/32.png) [@F022Y](https://forums.powershell.org/u/F022Y)\ **Post date:** [April 22, 2022, 8:40am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/4 "2022-04-22T08:40:21Z")

The only bit i’ve added is the $GPO6 and $TotalGPO6 across the script ---

**Author:** ![Olaf](https://sea1.discourse-cdn.com/flex019/user_avatar/forums.powershell.org/olaf/32/992_2.png) [@Olaf](https://forums.powershell.org/u/Olaf)\ **Post date:** [April 22, 2022, 9:20am UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/5 "2022-04-22T09:20:57Z")

Hmmm … I assume you do not use VSCode, do you? 😉 ![image](https://us1.discourse-cdn.com/flex019/uploads/powershell/original/2X/f/f1bb7fbb639bd4ffd8c7b3d80e6424f91ff23391.png) Either you remove the consecutive double quotes or you add a plus between them. Regardless of that - I urgently recommend for you to read about here strings. It could make your code way easier to read. > **[Informationen zum Anfügen von Regeln - PowerShell](https://docs.microsoft.com/de-de/powershell/module/microsoft.powershell.core/about/about_quoting_rules?view=powershell-7.2#here-strings)** > > Beschreibt Regeln für die Verwendung einzelner und doppelter Anführungszeichen in PowerShell. Next you may read about creating HTML reports with PowerShell. > **[How To Create An HTML Report With PowerShell](https://adamtheautomator.com/html-report/)** > > Learn how to use the PowerShell ConvertTo-HTML cmdlet and CSS to create a beautiful HTML report with PowerShell that makes the report easier to understand. That could make the HTML part way easier to write and to maintain if needed. ---

**Author:** ![dotnVo](https://avatars.discourse-cdn.com/v4/letter/d/4af34b/32.png) [@dotnVo](https://forums.powershell.org/u/dotnVo)\ **Post date:** [May 16, 2024, 8:18pm UTC](https://forums.powershell.org/t/help-with-a-legacy-script/19158/6 "2024-05-16T20:18:02Z")